r2687 - jhalfs/trunk/common

georgeb at linuxfromscratch.org georgeb at linuxfromscratch.org
Sat May 13 09:12:45 PDT 2006


Author: georgeb
Date: 2006-05-13 10:12:45 -0600 (Sat, 13 May 2006)
New Revision: 2687

Modified:
   jhalfs/trunk/common/func_validate_configs.sh
Log:
added write-priv validation to BUILDDIR test

Modified: jhalfs/trunk/common/func_validate_configs.sh
===================================================================
--- jhalfs/trunk/common/func_validate_configs.sh	2006-05-13 15:57:52 UTC (rev 2686)
+++ jhalfs/trunk/common/func_validate_configs.sh	2006-05-13 16:12:45 UTC (rev 2687)
@@ -169,11 +169,6 @@
   for config_param in ${!PARAM_GROUP}; do
     # This is a tricky little piece of code.. executes a cmd string.
     case $config_param in
-      BUILDDIR) # We cannot have an <empty> or </> root mount point
-                  echo -e "`eval echo $PARAM_VALS`"
-                  [[ "xx x/x" =~ "x${!config_param}x" ]] &&
-                       write_error_and_die
-                  ;;
       TIMEZONE)   echo -e "`eval echo $PARAM_VALS`" ;;
 
       # Validate general parameters..
@@ -227,6 +222,11 @@
       #  fatal   -z -d -w,
       #  warning -z+   -w+
       SRC_ARCHIVE) validate_dir -z+ -d -w+ ;;
+      BUILDDIR)   # The build directory/partition MUST exist and be writable by the user
+                  validate_dir -z -d -w
+                  [[ "xx x/x" =~ "x${!config_param}x" ]] &&
+                       write_error_and_die
+                  ;;
 
       # Validate files, testable states:
       #  fatal   -z -e -s -w -x -r,




More information about the alfs-log mailing list