cvs commit: LFS/bootscripts/lfs/init.d udev

Alexander E. Patrakov see at the.sig
Mon Jun 21 18:22:48 PDT 2004


Kevin P. Fleming wrote:
> alexander at linuxfromscratch.org wrote:
> 
>>   Index: Makefile
>>   ===================================================================
>>   RCS file: /home/cvsroot/LFS/bootscripts/Makefile,v
>>   retrieving revision 1.47
>>   retrieving revision 1.48
>>   diff -u -r1.47 -r1.48
>>   --- Makefile    18 Jun 2004 22:31:30 -0000    1.47
>>   +++ Makefile    21 Jun 2004 15:34:07 -0000    1.48
>>   @@ -1,10 +1,11 @@
>>    ETCDIR=/etc
>>    EXTDIR=${DESTDIR}${ETCDIR}
>>   +SHELL=/bin/sh

oops...

>>       all: install
>>       create-dirs:
>>   -    install -d -m 755 ${EXTDIR}/rc.d/rc{0,1,2,3,4,5,6,sysinit}.d
>>   +    /bin/bash -c 'install -d -m 755 
>> ${EXTDIR}/rc.d/rc{0,1,2,3,4,5,6,sysinit}.d'
>>        install -d -m 755 ${EXTDIR}/rc.d/init.d
>>        install -d -m 755 ${EXTDIR}/sysconfig
> 
> 
> The CVS commit message for this commit said "Add FIXME to udev 
> initscript", but included this change. I don't think it's a good idea to 
>  commit unrelated changes in a single commit, without at least including 
> the purpose of all of them in the commit message.

Sorry for that. I made this private modification to upgrade all my 
bootscripts after I found the problem with ash. Unfortunately, I forgot 
about that when doing the commit :(

> Also, what is this change supposed to accomplish? Setting SHELL in the 
> Makefile means make will use /bin/sh for everything, except this one 
> step that requires /bin/bash anyway. If we are still going to require 
> bash, why bother setting SHELL to anything else?

Nathan already fixed it. Thanks!

-- 
Alexander E. Patrakov
To get my address: echo '0!42!+/6 at 5-3.535.25' | tr \!-: a-z | tr n .



More information about the lfs-book mailing list