Type in Findutils in CVS 20030108

Chad Simmons polpak at yahoo.com
Thu Jan 9 10:06:04 PST 2003

--- Mark Lee <mplee at shaw.ca> wrote:
> Doesn't need to be removed if you use this patch instead.


>  /* util.c */
> -char *basename P_((char *fname));
> +char *basename2 P_((char *fname));

This can just be removed as with these changes the compiled form would just use
the standard basename function (prototyped in libgen.h). This is assuming
ofcourse that there is no functional difference between the standard basename
function and the one supplied in the source here. If there is then the author
of findutils may be expecting basename to behave differently, and we'll need to
account for that.


> diff -Naur findutils-4.1/find/util.c findutils-4.1.new/find/util.c
> --- findutils-4.1/find/util.c	1994-10-19 22:49:47.000000000 -0600
> +++ findutils-4.1.new/find/util.c	2003-01-08 16:30:59.000000000 -0700
> @@ -25,7 +25,7 @@
>     compressed into one slash. */
>  char *
> -basename (fname)
> +basename2 (fname)
>       char *fname;
>  {
>    char *p;
> diff -Naur findutils-4.1/lib/nextelem.c findutils-4.1.new/lib/nextelem.c

Again, no need to compile in pointless code. just remove it.


> diff -Naur findutils-4.1/lib/savedir.c findutils-4.1.new/lib/savedir.c
> --- findutils-4.1/lib/savedir.c	1994-10-07 11:21:34.000000000 -0600
> +++ findutils-4.1.new/lib/savedir.c	2003-01-08 16:30:36.000000000 -0700
> @@ -62,7 +62,7 @@
>  #define NULL 0
>  #endif
> -char *stpcpy ();
> +/*char *stpcpy ();*/

Why comment this prototype when the others are simply removed?

And again, these are /trivial/ changes to the code, and I would highly
recommend submitting it to the maintainer to fix. That way we don't have to
maintain this patch for each new version..

Chad Simmons

Version 3.1
GCS/L/C/O d-(+) s++: a-- C+++$>++++ UBLS++++$ 
P+++(--)$ L+++>++++ E--- W+>++$ N !o K? w(--) !O 
M- !V PS+ PE(++) Y+ PGP->+ t+ 5 X+() R(+) tv+@ 
b++(+++) !DI+++ D G(-) e>+++$ h---() r+++ y+++

Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
Unsubscribe: send email to listar at linuxfromscratch.org
and put 'unsubscribe lfs-dev' in the subject header of the message

More information about the lfs-dev mailing list