killproc arguments

Kevin P. Fleming kpfleming at linuxfromscratch.org
Sun Jul 25 10:41:02 PDT 2004


DJ Lucas wrote:

> -        if [ $# = 0 ]
> +        if [ "$PIDFILE" == "" || "$#" == "" ]

Any reason not to use:

if [ -z "$PIDFILE" -o -z "$#" ]

Using || here will probably work, but it's using an arithmetic operator 
where a logical operator makes more sense.



More information about the lfs-dev mailing list