Bug Found, 6.0-testing-20040910

Matthew Burgess matthew at linuxfromscratch.org
Sun Sep 12 06:51:51 PDT 2004


On Sun, 12 Sep 2004 07:46:37 -0600
Gerard Beekmans <gerard at linuxfromscratch.org> wrote:

> On Sun, 2004-09-12 at 03:32, djkaotica_ at hotmail.com wrote:
> > sed -i -e 's%^include ../MCONFIG%'\
> > '&\n\nCFLAGS:=$(CFLAGS) -fno-unit-at-a-time%' fdisk/Makefile
> > 
> > If assuming the \ after MCONFIG is to show that the command carries
> > to the next line, you get:
> > sed: -e expression #1, char 22: unterminated 's' command.
> > 
> > Otherwise, if added, you get an extra space before "include MCONFIG"
> > in the file, fdisk/Makefile.
> 
> Are you sure you didn't accidentally put a space after /MCONFIG%' and
> the backslash? Such a space would have the same result.

Hmmm, there seems to be a considerable room for error there though (I
for one almost always precede my '\' with a space when splitting command
lines.  Can we not split after the '-e ' flag to sed so the actual
expression isn't split, or does that screw up the layout?  i.e.:

sed -i -e \
's%^include ./MCONFIG%\n\nCFLAGS:=$(CFLAGS) -fno-unit-at-a-time$%' \
fdisk/Makefile

Cheers,

Matt.



More information about the lfs-dev mailing list