Improper handling of -p ${pidfile} in lfs-bootscripts

DJ Lucas dj at linuxfromscratch.org
Sat Mar 15 21:53:24 MDT 2008


Okay, perhaps I'm just being dense since I don't use the old bootscripts 
anymore, but wouldn't this simple change solve our ills with the samba 
script and others?  I mean, they seem to run correctly with the new 
pidofproc, which should be more transparent as to how they work, but 
this seems the best, IMO, to avoid a big change in the current scripts. 
  And as a side effect, we get a cool little change from yellow WARN to 
green OK on screen. :-)  For those affected, can you create a backup and 
give this change a try and test?  Works for samba and stale pids, or is 
that not the only issue to work around WRT to improper PIDFILE handling?

--- lfs/init.d/functions	(revision 8496)
+++ lfs/init.d/functions	(working copy)
@@ -567,8 +567,8 @@
  				return 0 # 4
  				;;
  			1)
-				log_warning_msg "Unable to continue: ${pidfile} exists"
-				return 0 # 4
+                                rm -f "${pidfile}"
+				log_warning_msg "removed invalid ${pidfile}"
  				;;
  			3)
  				;;


-- DJ Lucas



More information about the lfs-dev mailing list