r618 - trunk/iproute2

Matthew Burgess matthew at linuxfromscratch.org
Mon Aug 30 05:20:52 PDT 2004


On Mon, 30 Aug 2004 06:19:21 -0600
Archaic <archaic at linuxfromscratch.org> wrote:

> On Mon, Aug 30, 2004 at 11:50:44AM +0100, Matthew Burgess wrote:
> > 
> > Adding "install -m 0755 -d $(DESTDIR)$(MANDIR)/man8" at line 50 in
> > the Makefile fixes the installation.
> 
> I know a lot of Makefiles use the above method, but IMO it is *wrong*
> unless prefaced with an if/then.  The reason is that I don't like
> makefiles assuming I allow access for all to a certain directory. What
> if prefer 0750 for the dirs? The above, without a conditional, just
> overrode my authority. tsk, tsk.

Hey, I only copied the existing style of that Makefile :)  I agree with
your argument of course, but then you were already affected by this
Makefile, before I patched it :)

Cheers,

Matt.



More information about the patches mailing list