cvs commit: patches/coreutils coreutils-5.2.0-uname-x86-1.patch

Nico R. n-roeser at gmx.net
Tue Mar 2 15:23:22 PST 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I'm nit-picking once again... :-)

jim at linuxfromscratch.org wrote:
[...]
>   +     switch(ebx) {
>   +     case 0x756e6547: // Intel
[...]
>   +     case 0x68747541: // AMD
[...]
>   +     case 0x69727943: // Cyrix
[...]

Shouldn't ecx and edx be checked as well? Just to make sure.
Of course, the current version of the patch will work, but I'm getting
this slightly uncomfortable feeling ... ;-)

Have fun,
- -- 
Nico
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFARRduxI5uhYOGv4URAmmEAJ9fUzGPNde70CPKt+RG0oaOAfbeLQCghN4c
gFJ1+5Lg8wMff7IuzibElOE=
=5nql
-----END PGP SIGNATURE-----



More information about the patches mailing list